Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature 217 view issue threads without logging in #1505

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

Feature 217 view issue threads without logging in #1505

wants to merge 10 commits into from

Conversation

ashfaq1934
Copy link
Contributor

@ashfaq1934 ashfaq1934 commented May 4, 2023 •
edited
Loading

Threads app update

  • Created a new view to display the feed
  • Created views for adding and removing Civis
  • Created tests for new views
  • Updated feed template and view to display threads without having to register an account and removed placeholder from thread.html
  • Removed automatic site wide redirect in settings.py to allow the login view to redirect to different URLs. Modified login.html form to use next value if provided, and default to the base URL if not.
  • Moved landing page template to another view
  • Bug-fixes for less files not being found in about.html and how_it_works.html
  • Modified new thread button to direct the user to login if they haven't been authenticated, once they've logged in, they'll be redirected back to the thread
  • Fixed errors produced by ThreadDetailViewset and removed JSON encoding
  • Added section for messages in global_nav.html
  • Modified JavaScript in thread.html for card display and form submission. commented out code that was producing JavaScript errors and applied formatting fixes with flake8
  • Modified tests for landing and feed templates
  • closes View Issue Threads without Registering Account #217
  • relates to Port threads app templates to Django template syntax #1152

@ashfaq1934
Updated feed template and fixed bugs with loading less files
b985271 
- Created a new view to display the feed
- Updated feed template to display threads without having to register an account
- Bugfixes for less files not being found in about.html and how_it_works.html
- Modified new thread button to direct the user to login if they haven't been aurthenticated
@ashfaq1934
Update test_views.py
934a0ef
@ashfaq1934 ashfaq1934 changed the title Feature 217 view issue threads Feature 217 view issue threads without logging in May 4, 2023
@brylie brylie marked this pull request as draft May 5, 2023 11:33
codeclimate[bot]
codeclimate bot reviewed Jun 6, 2023
View reviewed changes
project/threads/templates/threads/thread.html Outdated Show resolved Hide resolved
project/core/templates/static/less/thread.less Outdated Show resolved Hide resolved
project/core/templates/static/less/thread.less Outdated Show resolved Hide resolved
codeclimate[bot]
codeclimate bot reviewed Jun 14, 2023
View reviewed changes
project/threads/views.py Outdated Show resolved Hide resolved
@ashfaq1934 ashfaq1934 marked this pull request as ready for review June 15, 2023 21:41
@ashfaq1934
Copy link
Contributor Author

The Linting in CI Workflow fails because of the Black formatting changes that might need to be applied
Screenshot from 2023-06-15 22-44-59
Screenshot from 2023-06-15 13-13-11
Should I apply Black formatting to these files so that the workflow passes?

@brylie
Copy link
Member

brylie commented Jun 16, 2023

Yes, all files should be formatted with ‘black’

@codeclimate
Copy link

codeclimate bot commented Jul 2, 2023

Code Climate has analyzed commit ca4ccfc and detected 0 issues on this pull request.

View more on Code Climate.

@ashfaq1934
Copy link
Contributor Author

ashfaq1934 commented Jul 2, 2023 •
edited
Loading

Here's a demo of the changes that have been implemented. Users will be able to create and delete civis. They can view threads but if they attempt to create a civi they will be redirected to the login url, after they login, they'll be redirected back to the thread they viewed.

demo_1.mp4

I've managed to get the workflow to pass by editing accounts/views.py which satisfied the linter.

Let me know if there's anything missing, hope this helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeclimate codeclimate[bot] codeclimate[bot] left review comments

@brylie brylie Awaiting requested review from brylie

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

View Issue Threads without Registering Account
2 participants
@ashfaq1934 @brylie